Generating a PDF splits the last line of text between two pages. That is the top half of the line of text (character ascenders) is on one page whilst the bottom half ( character decenders) is on the second page.

Originally reported at launchpad:

When I start rednotebook in Jaunty window appears with no text and locks up (freezes). When I run from the command line I get: [email protected]:~$ rednotebook INFO AppDir: /usr/share/rednotebook/rednotebook INFO BaseDir: /usr/share/rednotebook INFO First Start: False INFO RedNotebook version: 0.7.4 INFO System info: machine: x86_64, platform: Linux-2.6.28-13-generic-x86_64-with-Ubuntu-9.04-jaunty, processor: , python_version: 2.6.2, release: 2.6.28-13-generic, system: Linux, GTK version: (2, 16, 1), PyGTK version: (2, 14, 1), Yaml version: 3.08, INFO The config file /usr/share/rednotebook/rednotebook/files/default.cfg was read INFO The config file /home/andrew/.rednotebook/configuration.cfg was read /usr/share/rednotebook/rednotebook/gui/mainWindow.py:61: GtkWarning: gtk_toolbar_set_icon_size: assertion `icon_size != GTK_ICON_SIZE_INVALID' failed self.wTree = gtk.glade.XML(self.gladefile) INFO Cloud ignore list: ['filter', 'these', 'comma', 'separated', 'words', 'about', 'again', 'almost', 'looking', 'seems', 'stuff', 'which', 'whole', 'putting', 'going', 'handling', 'makes', 'unused', 'update', 'search', 'remove', 'removed', 'replacement', 'tomorrow', 'thing', "that's", 'there', 'solve', 'still', 'monday', 'looked', 'needs', 'items', 'files', 'fixed', 'folder', 'found', 'further', 'getting', 'having', 'helping', 'include', 'started', 'other', 'until', 'given', 'details', 'directory', 'discovered', 'email', 'enable', 'class', 'completed', 'building'] INFO Opening journal at /home/andrew/.rednotebook/data/ INFO 0.7.4 is newest version. You have version 0.7.4 INFO Connected Signals: 1 2 3 6 15 20

I then have to forcibly kill the application.

(Hello from EuroPython :-)

This isn't quite ready to go, but the day is drawing to a close, so I wanted to open a PR with what I'd got done. The aim is to use GtkSourceView for the day text editor, which brings built-in undo history and syntax highlighting. This could save a fair bit of code in RedNotebook, and also fix some UX quirks with undo.

I store the most recent 10 'source buffers' used, which preserve undo history and cursor position for the last 10 days viewed. Once a buffer falls out of this recent list, the undo history and cursor position for it are lost. It would be easy to increase the size of the recent list. I started small to make it easy to check the behaviour.

Bits to figure out:

• The UndoRedoManager in rednotebook also stores actions for the categories view. This can no longer be enabled, but the code is still there. If the plan is to remove this entirely, it's easy, because we can just use the GtkSourceView undo system (as in this PR). If the categories view is coming back in some form and undo should remain integrated, it's more complex.
• The txt2tags highlighting mode for GtkSourceView doesn't seem to be very good. This is defined in an XML file. I think it's possible to ship a modified XML file separately and use it if necessary, but we're also interested in the possibility of using markdown, since it's so much more widely known.

Originally reported by nick222-yandex at https://bugs.launchpad.net/bugs/1068655 (2012-10-19T14:08:23Z):

After update from Ubuntu 12.04 to Xubuntu 12.10 - Rednotebook cannot open and cannot create any files anywhere except home user folder...

When I try to create new journal in another folder - it created in my main user folder.

After installation of RedNotebook 2.3 on Windows7 I am not able to read or enter Thai language text in Edit Page which was working fine in earlier versions. Can read OK only in the Preview but that is annoying as I hardly use the Preview.

Originally reported by spamtostefan at https://bugs.launchpad.net/bugs/663944 (2010-10-20T14:54:04Z):

Running the German version of RedNotebook 1.1.1 under Windows7 images neither show up in preview mode nor in exported pdf files. Exported html is fine and shows all images.

Versions

RedNotebook version: 2.4 (the issue happened somewhere between 1.10 and 2.4, since I was happily using 1.10.1 for a long time, until spellcheck stopped working and I was forced to update).

Operating system and version: Ubuntu 16.04.4 LTS (Xenial Xerus)

Expected behavior

1. The text search works with partial word match.
2. The text search works in case insensitive mode.

Actual behavior

1. Trying to search the word without typing one or more leading letters never works.
2. Trying to search the word without typing one or more trailing letters sometimes works, sometimes it doesn't.
3. Trying to search the word without typing the letters in needed case (upper or lower) sometimes works, sometimes it doesn't.
4. Trying to search a phrase containing non-alphanumeric characters (e.g. parenthesis) leads to the non-alphanumeric characters being utterly ignored during search.

Steps to reproduce the behavior

To reproduce 1: make a journal, pick a word from it, remove its first letter, and try to perform search. To reproduce 4: make a journal, type something like (abc), then try to search something like !abc!.

Log output when reproducing behavior

($HOME/.rednotebook/rednotebook.log or C:\Users<username>.rednotebook.log)

https://gist.github.com/ScumCoder/4795ce79add92df87286bd3a8ecd8e28 (it doesn't contain anything suspicious).

Fresh brand new RedNotebook 1.1.3 from robin.powdarrmonkey.net repo.

Started once and became unwilling to start again after a reboot.

================================

The console output is:

[email protected]:~$ rednotebook /usr/share/themes/Kiwi/gtk-2.0/gtkrc:78: Murrine configuration option "scrollbar_color" is no longer supported and will be ignored. /usr/share/themes/Kiwi/gtk-2.0/gtkrc:82: Murrine configuration option "gradients" is no longer supported and will be ignored. INFO Writing log to file "/home/myo/.rednotebook/rednotebook.log" INFO Set default locale: "ru_RU" INFO Module glade found INFO Running in portable mode: False INFO First Start: False INFO RedNotebook version: 1.1.3 INFO System info: machine: i686, platform: Linux-2.6.32-30-generic-i686-with-Ubuntu-10.04-lucid, processor: , python_version: 2.6.5, release: 2.6.32-30-generic, system: Linux, GTK version: (2, 20, 1), PyGTK version: (2, 17, 0), Yaml version: 3.09 INFO Using webkit for previews: 1 Traceback (most recent call last): File "/usr/bin/rednotebook", line 12, in rednotebook.journal.main() File "/usr/share/rednotebook/rednotebook/journal.py", line 687, in main journal = Journal() File "/usr/share/rednotebook/rednotebook/journal.py", line 292, in init self.frame = MainWindow(self) File "/usr/share/rednotebook/rednotebook/gui/main_window.py", line 157, in init self.load_values_from_config() File "/usr/share/rednotebook/rednotebook/gui/main_window.py", line 653, in load_values_from_config self.main_frame.move(pos_x, pos_y) TypeError: an integer is required

================================

The strings in configuration.cfg that could possibly cause this error are:

mainFrameX=None mainFrameY=None

Versions

RedNotebook version (make sure you have the latest version): 2.11.1 (rednotebook-git package)

Operating system and version: Linux 5.3.6-1 Manjaro (Arch derivative) x86_64

Expected behavior

Using ">" at the beginning of a line results in blockquote formatting when previewing the text.

Actual behavior

There doesn't seem to be any support for blockquotes. When using the markdown, then previewing, the ">" characters are left visible and there is no blockquote formatting.

(It seems like maybe this feature just isn't implemented. It would be a great feature to have in a journal, since some people (myself included) like to include interesting or inspirational quotes when journaling. If this isn't a feature yet, may I please suggest it be added in a future release?)

Steps to reproduce the behavior

Add lines starting with ">" then press Preview, and the lines are not formatted like blockquotes.

Log output when reproducing behavior

There is nothing relevant in the log. It registered past instances of saving, nothing relevant to formatting blockquotes.

The option to install it on MacOS are to complex (on top of that macport is relatively unstable and messy) for most users. Would be great to generate a MacOS app.

Originally reported by jani-valtari at https://bugs.launchpad.net/bugs/1498044 (2015-09-21T14:56:16Z):

I have been useing RedNotebook for 9 months now, making some notes almost every day. It has been working fine, but it started hanging all of a sudden after I installed latest version 1.10.2. Seems to happen at the point when it is auto-saving my writing to text files. And after it hangs, I am not able to start it anymore - if I shut it down and try to restart, it just hangs immediately again. The only way to get rednotebook running again is to manually open the text file what it saved last, and then manually remove the latest entry. After that I am again able to start RedNotebook again.

So it seems to me, that RedNotebook saves something corrupt to the text file, and then hangs. The file looks perfectly fine to me ( if I open it e.g. via Notepad++). I just need to manually remove the last entry. If I then copy-past the exact same deleted content on the RedNotebook UI (and remove all the extra escape characters what RedNotebook stores to text files). It is still fine. So the issue does not seem to be in the actual text content itself, but something else corrupts the file...

I use Windows 7 Enterprice as OS.

Summary of the changes in this pull request

I scanned the entire codebase for potential issues regarding performance and readability and fixed as many issues as possible. This should make the codebase "modern" and more cleaner to read/review through.

These fixes include:

• Better named expressions added
• f-strings added rather than interpolated variable names
• better conditional branching added (which is a good practice and follows standards laid out by the Python community)
• code made more readable following "pythonic" code style
• improved formatting based on PEP8 guidelines
• added list comprehensions wherever needed replacing large, complex-looking code blocks
• TODO.md formatted based on Markdown file guidelines.

Pull request checklist

• [x] I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
• [x] If applicable: I have removed the corresponding entry in TODO.md.

Summary of the changes in this pull request

• TODO

Pull request checklist

• [ ] I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
• [ ] If applicable: I have removed the corresponding entry in TODO.md.

Looking in the documentation it seems that the format in the month text file only allows for one entry per day as the day date is used as an index. Would it be feasible to allow more than one entry per day without having to create a separate journal? If you manually put a second text: entry under the same date only the second one is shown. If you manually put a suffix letter after the date then it complains that it is not an integer

To facilitate sharing with other systems you will need to add some metadata to the daily files.

• Calendar date - currently implied by the filename and the day number in the text file, the date the entry is associated with should be available somewhere as a date field.
• Created date - the actual date the entry was created, not the calendar date (not user editable)
• Modified date - the date the entry was last modified (automatically updated on save - used to determine sync status with a CalDav server copy
• Categories (Tags) - one word text tags to group and search entries
• Status (Draft, Final, Cancelled)
• Class (Public,Private,Confidential)

There may also be more. Do you have a structured format for storing this information in the text file? This would also all be useful info to have available in the display

I hope you don't mind if I put them all in one issue. I don't see much reason to separate them.

Is your feature request related to a problem? Please describe.

1. Importing media into the app is a repetitive process, with having to open the file selection menu every time. Alongside the apparent inability to change/set a default location, requiring you to navigate to your desired directory each time you want to import a file. Sure, there's bookmarking, but that's not really my point.

2. Default image size is the image's actual size, often (in my case) being far too big to fit on the screen without scrolling.

Describe the solution you'd like

1. Dragging and dropping files into the app, preferably putting it on the same line as your mouse is under at the time of releasing the button.

2. Allow configuration of image size to be either proportional to the window size (Shrinking and growing accordingly as you adjust the window size), and/or choosing the preview size after importing, preferably (configurable, perhaps) defaulting/starting with a small preview, or simply scaling with window size at the time of importing. Additionally, if the image is larger than displayed, allow clicking it to show a bigger/full version either (or make it configurable between the two) within the app window or in your default image viewer.

3. Add an option to load image previews regardless of whether user is in preview mode or edit mode.

4. (Low priority) I don't mind the style of the main app window, but it would be nice to be able to change the style of the file select menu to that of the user's operating system (Or just have one matching Windows 10).

Describe alternatives you've considered

1. None.

2. None.

3. Automatically view past days (ones that aren't empty) in preview mode (Of course, with the option to switch back to edit mode).

4. Simply add a scale option to make the distance between texts i.e directories on the side smaller.

Versions:

• RedNotebook version 2.24 (Installed via Scoop in case that matters, not that I think it should.)
• Operating system and version: Windows 10 Pro build 19043.1526

Thanks very much in advance. I understand to an extent (My only firsthand experience with code is basic AutoHotKey) that it may not be easy or quick to implement some/all/any of this, but if there's one thing I would like most, it's the image size configuration ability.

Summary of the changes in this pull request

non-linux releases of rednotebook are a bit of a pain. So for all those of you out there who know how to both xwindows and docker, why not just run it on a linux container?

I dont know how useful this is for others, it is certainly useful for me for when I switch mac laptops and dont want to have to do a giant dance involving brew, gtk installations and lots of time.

As a side note, I believe the icon theme listed on line 20 is missing from your ubuntu apt definition. I got a bunch of warnings before I installed that.

Pull request checklist

• [x] I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
• [ ] If applicable: I have removed the corresponding entry in TODO.md.