Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

Traceback during open 'Create' page (url for example): http://127.0.0.1:8000/admin/user/create

File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/starlette/templating.py", line 37, in init content = template.render(context) File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/jinja2/environment.py", line 1301, in render self.environment.handle_exception() File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/jinja2/environment.py", line 936, in handle_exception raise rewrite_traceback_stack(source=source) File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqladmin/templates/create.html", line 1, in top-level template code {% extends "layout.html" %} File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqladmin/templates/layout.html", line 1, in top-level template code {% extends "base.html" %} File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqladmin/templates/base.html", line 15, in top-level template code {% block body %} File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqladmin/templates/layout.html", line 49, in block 'body' {% block content %} {% endblock %} File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqladmin/templates/create.html", line 18, in block 'content' {{ field() }} File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/wtforms/fields/core.py", line 172, in call return self.meta.render_field(self, kwargs) File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/wtforms/meta.py", line 64, in render_field return field.widget(field, **render_kw) File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/wtforms/widgets/core.py", line 174, in call kwargs["value"] = field._value() File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/wtforms/fields/datetime.py", line 36, in _value return self.data and self.data.strftime(self.format[0]) or "" File "/Users/iuliia_volkova2/Library/Caches/pypoetry/virtualenvs/admin-panel-service-Ji2bEy0B-py3.7/lib/python3.7/site-packages/sqlalchemy/sql/elements.py", line 582, in bool raise TypeError("Boolean value of this clause is not defined") TypeError: Boolean value of this clause is not defined

Steps to reproduce the bug

I think something in model cause in issue - I send the sample

Also we use async SQLAlchemy engine. I will be glad if you will do some input where to dig or what can be a reason of the problem.

Expected behavior

Create form open correctly without issues.

Actual behavior

Impossible to open Create form

Debugging material

No response

Environment

SQLAdmin == 0.1.9 SQLAlchemy == 1.4.37

Additional context

No response

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

I used SQLAdmin in my personal project(That's awesome 🥳), But the datetime field need to enter manually:

Maybe choose from panel is better:

Steps to reproduce the bug

No response

Expected behavior

No response

Actual behavior

No response

Debugging material

No response

Environment

os: mac python: 3.9 sqladmin: lastest

Additional context

No response

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

When we go on the sql edit admin interface, the Relationship field are not correctly displayed. see the sample code. Only one relation is created between foos and bars. But here is what is displayed

And when we click on edit

On the detailed view everything is fine though

Steps to reproduce the bug

Sample code

from sqlmodel import Field
from sqlmodel import Relationship
from sqlmodel import SQLModel
from typing import Optional, List
from app.db import create_db_and_tables
from sqlmodel import Session
from app.db import engine 
from sqladmin import ModelAdmin
from app.app import admin


class FooTable(SQLModel, table=True):
    """
    FooTable class, in one to many relationship with BarTable
    """
    __tablename__ = 'foo_table'
    id: Optional[int] = Field(default=None, primary_key=True)
    value: float
    bars: List['BarTable'] = Relationship(back_populates='foo')
        
class BarTable(SQLModel, table=True):
    """
    BarTable class, in many to one relationship with FooTable
    """
    __tablename__ = 'bar_table'
    id: Optional[int] = Field(default=None, primary_key=True)
    foo_id: Optional[int] = Field(default=None, foreign_key='foo_table.id')
    foo: Optional['FooTable'] = Relationship(back_populates='bars')
create_db_and_tables(BarTable)


with Session(engine) as session:
    for i in range(100):
        session.add(FooTable(value=i))
        session.add(BarTable(value=i))
    foo_100 = FooTable(value=100)
    session.add(foo_100)
    session.add(BarTable(value=i, foo=foo_100))
    session.commit()

    
class FooAdmin(ModelAdmin, model=FooTable):
    column_list = [FooTable.id, FooTable.value]
    
class BarAdmin(ModelAdmin, model=BarTable):
    column_list = [BarTable.id]
    

admin.add_view(FooAdmin)
admin.add_view(BarAdmin)

Expected behavior

Either the Relationship field should not be edited, or just the foreign key field should appear in the edit template.

Actual behavior

The relationship Fields cannot be edited AND the whole other table is displayed there

Debugging material

No response

Environment

Python 3.10 (python:3.10-slim base image). Latest sqladmin==0.3.0

Additional context

No response

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

When going on /list the SELECT SQLAlchemy statement fails with the following error :

We have an InvalidColumnReference SELECT DISTINCT, ORDER BY expressions must appear in select list

I'm having this error only on a specific model which has a One to One on another table (lazy="subquery")

It seems to be order_by should use the column and not the column name

Steps to reproduce the bug

I'm having Two models, roughtly

class PublicationOrm(Base):
    __tablename__ = "publications"
    id = Column(String, primary_key=True)

    ...

    profile_picture_id = Column(String, ForeignKey("images.id"))
    _cropped_profile_picture = relationship(
        "ImageOrm", lazy="subquery", foreign_keys=[profile_picture_id])


class ImageOrm(Base):
    __tablename__ = "images"

    id = Column(String, primary_key=True)
    _filename = Column("filename", String)
    x = Column(Integer)
    y = Column(Integer)
    width = Column(Integer)
    height = Column(Integer)

I expect someone having this setup and getting the /list page to have a 500 error (see above)

Expected behavior

No error

Actual behavior

500 error

Debugging material

No response

Environment

• Ubuntu 20
• python 3.9.5
• sqlalchemy ==1.4.37

Additional context

No response

Fix to use zip for iterating over the formatted values. It prevents retrieving formatted_value by index especially when it is Iterable but not Sequence.

Ref. #204.

I tried adding the login function. Including the following:

1. A User model
2. A script to create a user
3. Reads the fields required for user-generated passwords from. Env.
4. Login html can use i18n and Chinese.

Now there has some question: 1.I don't know how to create an executable with setup.py.(I can only use poetry to create a program by tool.poetry.scripts) 2. Most of this update is from my old project.But it need deeply test. 3. Doc need update.

In new version,you need create a .env in project's root.And .env need this data(like this): SECRET_KEY=aawinjwol;egbfnjek bnl DATABASE_URL=sqlite:///example.db

If you want to create a manager: bash

sqladmin username password

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

I would like to edit in my database, yet when I click on the edit button I get an Internal Server Error with the following server error message

...
api-web-1  |   File "/usr/local/lib/python3.10/site-packages/sqladmin/helpers.py", line 118, in get_primary_key
api-web-1  |     assert len(pks) == 1, "Multiple Primary Keys not supported."
api-web-1  | AssertionError: Multiple Primary Keys not supported.

Do you know how to fix it?

Steps to reproduce the bug

class User(SQLModel, table=True):
    user_id: str = Field(primary_key=True, nullable=False)
    e_mail: EmailStr

class UserAdmin(ModelView, model=User):
    column_list = [User.user_id]
    column_searchable_list = [User.user_id]

admin = Admin(app, engine)

admin.add_view(UserAdmin)

Expected behavior

No response

Actual behavior

No response

Debugging material

No response

Environment

• MacOS
• Python 3.10
• SQLAdmin 0.6.1

Additional context

No response

Adds a setup file for pre-commit. This allows the linters to be ran in local before pushing a pr. To install do the following:

• Type in pip install pre-commit
• Inside an individual repo type in pre-commit install
• After this users will have to fix linting issues before a commit will go through.

Note: The pre-commit hooks can be skipped by adding -n to a commit

The following linters were added:

• autoflake: used in github actions
• isort: used in github actions
• black: used in github actions
• flake8: used in github actions
• Some basic builtins: check-yaml, end-of-file-fixer, trailing-whitespaces, check-merge-conflict, detect-private-key
• codespell: makes sure that words in code are spelled correctly
• pyupgrade: checks for outdated syntax in python

This PR attempts to add the remaining sqlachemy_utils data types. Complete list here: https://sqlalchemy-utils.readthedocs.io/en/latest/data_types.html#module-sqlalchemy_utils.types.choice. Notes for each one appear below:

• ArrowType: already implemented
• ChoiceType: got this to work, but implementation is not super user friendly. Would love suggestions for a better implementation
• CompositeType: postgres specific and I use mysql (:, skipping
• ColorType: implemented
• CountryType, CurrencyType, LocalType, WeekDaysType: currently breaks if nothing is sent to the form, this seems to be common among all forms using Babel. @aminalaee do you have any suggestion on how I could fix this?
• : already implemented
• EmailType: Did in #150
• EncryptedType: currently this uses a binary encryption which is not practical to type into a form. Based on their documentation this will be changed to a string implementation in the future and we can implement then.
• JSONType: implemented
• LtreeType: postgres specific and I use mysql (:, skipping
• IPAddressType: Did in #150
• PasswordType: implemented
• PhoneNumberType: This uses composite type, how do we want to implement it?
• ScalarListType: implemented, however adding an item does not work well (I still think a bad implementation is better than the presence of the field crashing the server)
• TimezoneType: implemented
• TSVectorType: postgres specific and I use mysql (:, skipping
• URLType: already implemented
• UUIDType: already implemented

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

I am trying to update m2m field in form but i am getting error "sqlalchemy.exc.InvalidRequestError: Can't attach instance another instance with key is already present in this session"

Steps to reproduce the bug

No response

Expected behavior

No response

Actual behavior

No response

Debugging material

No response

Environment

Macos , python 3.9

Additional context

No response

Long story short: fixes #104.

Locking the dependency uses mkdocstrings's so-called "experimental" handler for docstring parsing. The new one properly parses the docstring in this case whereas the legacy one does not.

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

If field of model has PhoneNumberType from sqlalchemy_utils, you cannot create or edit new records.

Steps to reproduce the bug

1. Made model with
2. Add to admin panel.
3. Try to create new one or update old one.

Expected behavior

Can edit and create new records.

Actual behavior

Getting Internal Error.

Debugging material

Traceback (most recent call last):
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/uvicorn/protocols/http/httptools_impl.py", line 419, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/fastapi/applications.py", line 270, in __call__
    await super().__call__(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/cors.py", line 84, in __call__
    await self.app(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/routing.py", line 443, in handle
    await self.app(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/sessions.py", line 86, in __call__
    await self.app(scope, receive, send_wrapper)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
               ^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/authentication.py", line 56, in wrapper_decorator
    return await func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/application.py", line 465, in edit
    Form = await model_view.scaffold_form()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/models.py", line 1005, in scaffold_form
    return await get_model_form(
           ^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/forms.py", line 536, in get_model_form
    field = await converter.convert(
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/forms.py", line 302, in convert
    converter = self.get_converter(prop=prop)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/aryadovoy/Documents/coding/back/.venv/lib/python3.11/site-packages/sqladmin/forms.py", line 255, in get_converter
    raise NoConverterFound(  # pragma: nocover
sqladmin.exceptions.NoConverterFound: Could not find field converter for column phone_number (<class 'sqlalchemy_utils.types.phone_number.PhoneNumberType'>).

Environment

OS: Fedora Linux 35 (KDE Plasma) x86_64 Python: 3.11.0 SQLAdmin: 0.8.0

Additional context

No response

Checklist

• [X] There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.

I want to be able to add inline model like in flask-admin. I think it's very helpful feature

Describe the solution you would like.

No response

Describe alternatives you considered

No response

Additional context

No response

Checklist

• [X] There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.

Identity is not overwritten in metaclass even if in attrs cls.identity = slugify_class_name(model.__name__)

Describe the solution you would like.

It should be possible to create something like cls.identity = attrs.get("identity", slugify_class_name(model.__name__)

Although edit links will need to be updated accordingly, of course.

Describe alternatives you considered

No response

Additional context

No response

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

Model relations are automatically loaded regardless of the ModelView configuration, this causes issues with relationships defined as lazy="dynamic" because it ends up in InvalidRequestError( '%s' does not support object population - eager loading cannot be applied.) from sqlalchemy. The error is raised on any list or detail request.

The current workaround I'm applying is:

class ModelView(ModelView):
    def __init__(self) -> None:
        super().__init__()
        self._relations = [rel for rel in self._relations if rel.lazy != "dynamic"]

Steps to reproduce the bug

Setting up two SQLAlchemy Models and configuring a relationship between them with the lazy="dynamic" parameter should suffice

Expected behavior

1. Relationships not being listed as part of column_list or column_details_list are not eagerly loaded
2. Relationships with lazy="dynamic" are either ignored (short term fix?) or correctly handled (longer term feature?)

Actual behavior

InvalidRequestError causes the ModelView to be unusable for models with lazy="dynamic" relationships

Debugging material

Starlette Debugger.pdf

Environment

• OS: Debian 11 (Bullseye)
• Python: 3.11
• SQLAlchemy: 1.4.44

Additional context

No response

Checklist

• [X] There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.

I'd like to be able to use this with the Starlite framework.

Describe the solution you would like.

Starlite recently removed the Starlette dependency, limiting the ability to use this tool on that framework. I would like to contribute to a solution that works with Starlite.

I'm looking for guidance on how best to integrate this functionality. (i.e. separate fork, PR to integrate into main)

Describe alternatives you considered

No response

Additional context

No response

Checklist

• [X] The bug is reproducible against the latest release or master.
• [X] There are no similar issues or pull requests to fix it yet.

Describe the bug

I want to add a file download. But if I add a file widget, it comes with a string instead of a file. How can this be fixed?

class IconAdmin(ModelView, model=Icon):
    form_columns = [Icon.name, Icon.file]
    form_overrides = dict(file=FileField)

The file field in the icon model has a string type. Could this be the problem? And if so, what needs to be fixed?

Steps to reproduce the bug

No response

Expected behavior

No response

Actual behavior

No response

Debugging material

No response

Environment

python 3.9.13 sqladmin 0.4.0 sqlmodel 0.0.6

Additional context

No response