code review

This paper is finally updated at 781 Days ago, , The information may have developed or changed .

• new Date(xx.getTime() + 5 * 1000) Time operation , Please use calendar class or java 8 Time class of , Reduce redundancy new Date objects creating
• Arrays.asList(xx).stream() Take a look for yourself Arrays.asList() The source code. ,Arrays.stream(new Object[]{spVO}) Is it not fragrant ？ Create a list of individual elements Collections.singletonList() It's OK
• if Condition code redundancy

if(a&&b){
    return true;
}
if(b&&c){
    return true;
}

Copy

• VO Is it necessary to define ？ The highest principle is PO Those that can be returned directly do not need to be converted into VO
• Created cache It's local cache , Could you tell me about the two nodes of on-site deployment , Add or delete operations can only be handled by one node , How to refresh another node ？ Load without startup , The cache after use is also very fragrant ？

// Please pay attention here , Need to be converted to List Do preservation 
List<String> xx = JSON.parseArray(item.getxx(), String.class);
//  The front end also needs to be specially handled  xx.js
 item.xx = JSON.parse(item.xx);

Copy

• The above code needs to be manually converted , have access to @Convert Annotation complete conversion , No intrusion into business logic code , The front end and back end do not need to be forced .@Convert(converter = StringToListConverter.class)
• Enumeration classes do not provide set Method Enumeration class is jdk A grammar sugar of , Its essence is realized through ordinary classes , Only the compiler has processed for us , The compiled bytecode of each enumeration type is essentially inherited from Java.lang.enum Enum type of the same name ordinary class , Each enumeration constant is essentially a static constant object of a common class with the same name as the enumeration type , All enumeration constants are assigned to initialization instances through static code blocks . When used set Method for assignment , In fact, it is to modify the value of a static variable in memory , The original meaning of this value has been modified , At this time, if other places judge again , Inevitable error .
• controller You can set global exception capture unified processing , ``@ControllerAdvice @ExceptionHandler`
• VO Generally used for page , Data transmission shall use DTO( In fact, the instance names are all right )
• xx No, override toString Method , Directly through log.error You can't see the parameters when printing
• The implementation classes inside the package but not outside the package should not be used public Avoid the problem of quoting everywhere
• The extracted tool class needs to be extracted It has nothing to do with business , Try not to be in service Internal maintenance , Tools should be mentioned or should be mentioned
• The collection will be judged empty before the database search , avoid sql abnormal
• To implement class naming, you need to add Impl distinguish

Post Views: 339