This is the first of the three like in PyAMI. This PR moves all source files from pybert to src/pybert. Some of the repeated pybert_pybert have been removed and reorganized. Really want you thoughts on names, tried to organize best as I understand it and how I think it could grow.

The Python Packaging Authority has started pushing that packages adopt a src folder structure. This does not change any of the current functionality or usage as a GUI application. It would affect anyone who has integrated it into a larger application.

• Moves the files under the src/ folder and fixes their imports.
• Changes some of the filenames to not have the pybert_*.
• Since enable fixed their build, we can actually install via pip. Update setup.py to allow that. This will be replaced in the next PR by a pyproject.toml file.
• Corrects pyibisami imports from capn-freako/PyAMI#17

Updated:

./src
└── pybert
    ├── __init__.py
    ├── __main__.py
    ├── configuration.py  (was `pybert_cfg.py`)
    ├── images
    │   └── icon.png  (moved out some images that were not part of the application)
    ├── parsers
    │   ├── __init__.py
    │   └── hspice.py  (I don't see this being used anywhere but gives us room to expand support)
    ├── pybert.py
    ├── results.py (was `pybert_data.py`)
    ├── sim
    │   ├── __init__.py
    │   ├── cdr.py
    │   ├── dfe.py
    │   └── simulation.py (was `pybert_cntrl.py`.  Somewhat redundant with the import of sim.simulation.)  The idea being that a "sim" could be run without the gui or like how the CLI could enable.
    ├── solvers
    │   ├── __init__.py
    │   ├── simbeor
    │   │   └── __init__.py
    │   └── solver.py
    ├── utility.py (was `pybert_util.py`)
    └── visual
        ├── __init__.py
        ├── help.py  (was `pybert_help.py`)
        ├── plot.py   (was `pybert_plot.py`)
        └── view.py (was `pybert_view.py`)

Last one of the three like in pyibisami. Anything beyond this should be altering features/adding features and will denote them as such.

• Just gets the low hanging from from running tox -e format and tox -e lint which clear up a large majority of pylint's complaints or increases the score of 7.4 to 8.76 out of 10.0.
• Updates mypy to work with the src/ structure which is run with tox -e type-check cleaned up an error or two and told it to skip simbeor.

Simulations with PyBERT 3.5.1 using Anaconda3 2021.11 that has Python 3.8.12 (does PyBERT force this version rather than using 3.9?) fail using a channel file and using native channel definition.

With 4-port S-parameter file (Touchstone 1.0 and 2.0 formats), error is: ts2N = import_freq(filename) TypeError: import_freq() missing 1 required positional argument: 'freqs'

With native channel definition, error occurs during plotting: start_ix = where(clock_times > start_t)[0][0] TypeError: '>' not supported between instances of 'list' and 'int'

I've created pybert64 env and did this: conda install -c dbanas pybert

Anaconda gave the following errors...

Collecting package metadata (current_repodata.json): done Solving environment: failed with current_repodata.json, will retry with next rep odata source. Initial quick solve with frozen env failed. Unfreezing env and trying again. Solving environment: failed with current_repodata.json, will retry with next rep odata source. Collecting package metadata (repodata.json): done Solving environment: failed

PackagesNotFoundError: The following packages are not available from current cha nnels:

How can I install it manually ? Seems anaconda can't find pybert package in it's cloud.

Hi

I am trying to follow your guide in Win10, but I am getting the following errors:

(C:\Program Files\Anaconda2) C:\WINDOWS\system32>python -m pybert Traceback (most recent call last): File "C:\Program Files\Anaconda2\lib\runpy.py", line 174, in _run_module_as_main "main", fname, loader, pkg_name) File "C:\Program Files\Anaconda2\lib\runpy.py", line 72, in run_code exec code in run_globals File "C:\Program Files\Anaconda2\lib\site-packages\pybert_main.py", line 1, in from pybert import * File "C:\Program Files\Anaconda2\lib\site-packages\pybert\pybert.py", line 72, in from pybert_view import traits_view File "C:\Program Files\Anaconda2\lib\site-packages\pybert\pybert_view.py", line 19, in from pybert_cntrl import my_run_sweeps File "C:\Program Files\Anaconda2\lib\site-packages\pybert\pybert_cntrl.py", line 25, in from pybert_util import find_crossings, make_ctle, calc_jitter, moving_average, calc_eye, import_qucs_csv File "C:\Program Files\Anaconda2\lib\site-packages\pybert\pybert_util.py", line 22, in from pylab import plot, show, legend File "C:\Program Files\Anaconda2\lib\site-packages\pylab.py", line 1, in from matplotlib.pylab import * File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\pylab.py", line 274, in from matplotlib.pyplot import * File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\pyplot.py", line 114, in _backend_mod, new_figure_manager, draw_if_interactive, show = pylab_setup() File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\backends_init.py", line 32, in pylab_setup globals(),locals(),[backend_name],0) File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\backends\backend_qt5agg.py", line 16, in from .backend_qt5 import QtCore File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\backends\backend_qt5.py", line 31, in from .qt_compat import QtCore, QtGui, QtWidgets, _getSaveFileName, version File "C:\Program Files\Anaconda2\lib\site-packages\matplotlib\backends\qt_compat.py", line 175, in "Matplotlib qt-based backends require an external PyQt4, PyQt5,\n" ImportError: Matplotlib qt-based backends require an external PyQt4, PyQt5,

I am no sure what to do. You help is greatly appreciated. Thank you

Catalin

PyBERT used to use an ASCII format for the configuration file. This allowed me to create files with a program and then start PyBERT and I'd pick the configuration file I wanted to use for that simulation. Now that PyBERT 3.4.2 uses a binary format, I can't do that. Consider loading and saving the old or new formats or switching back to the ASCII format.

I followed the instruction below using Anaconda2(64bit) conda install enable conda install traitsui conda install chaco conda install kiwisolver conda install scipy conda install Sphinx conda install matplotlib pip install PyBERT python -m pybert

Looks the installs are almost good except the last one when run "python -m pybert" There are still several errors or warnings. Not sure if they are critical

C**:\python\Anaconda2\lib\site-packages\pybert-2.0.2-py2.7.egg\pybert\pybert.py:1139: VisibleDeprecationWarning: using a non-integer number instead of an integer will result in an error in the future C:\python\Anaconda2\lib\site-packages\chaco\array_data_source.py:123: FutureWarning: comparison to None will result in an elementwise object comparison in the future. self._data = newdata C:\python\Anaconda2\lib\site-packages\traits\trait_handlers.py:1599: FutureWarning: comparison to None will result in an elementwise object comparison in the future. if value in self.values: C:\python\Anaconda2\lib\site-packages\chaco\image_data.py:190: FutureWarning: comparison to None will result in an elementwise object comparison in the future. self._data = newdata Traceback (most recent call last): File "C:\python\Anaconda2\lib\runpy.py", line 162, in _run_module_as_main "main", fname, loader, pkg_name) File "C:\python\Anaconda2\lib\runpy.py", line 72, in run_code exec code in run_globals File "build\bdist.win-amd64\egg\pybert_main.py", line 3, in File "C:\python\Anaconda2\lib\site-packages\traits\has_traits.py", line 2156, in configure_traits kind, handler, id, scrollable, args ) File "C:\python\Anaconda2\lib\site-packages\traitsui\toolkit.py", line 245, in view_application raise NotImplementedError NotImplementedError**

I have attached a configuration file I had PyBERT 3.5.5 load and then I saved it with a new name, also attached. PyBERT is not reading some fields and is using defaults instead. PyBERT.zip

Add command-line options for PyBERT when it loads to do one, multiple, or all of the following...

1. Load configuration
2. Save configuration
3. Load results
4. Save results
5. Run
6. Exit with options to save results and/or configuration or no option at all
7. Repeat with another set of options

A possible scenario is load config, run, save results, exit. Another scenario might be to load config, load results, run, and then pass to manual control.

Hi David,

Below are my thoughts on a possible way forward, which I'm currently coding up for demo purposes. Please, let me know what you think.

Thanks! -db

Thoughts on how to proceed w/ development on tx-rx-split branch

Regarding the new v3.2.0 version of PyBERT (first one w/ new sub-tabbed layout), both David Patterson and I dislike the way the Tx/Rx configuration is currently split between the Config. and Channel tabs. The following are my thoughts on how to proceed. We've created a branch: tx-rx-split, specifically for this work.

The obvious first impulse is to unify all Tx/Rx configuration, rather than have it split between two tabs. However, I don't think it's quite that simple. The problem is the Tx/Rx both have equalization-related and channel-related attributes. For instance, the Tx output drive stage properties are intimately associated with the channel impulse response, while the Rx CTLE is closely associated w/ the CDR/DFE. And the more I think about this, the more I believe that it makes sense to have the channel-related Tx/Rx attributes configured separately from the equalization-related attributes. However, I think we may currently have the positions of those two sets flipped from what really makes sense. I think I'd like to try the following and run it by David, to see what he thinks:

• Rename the Channel tab to Equalization.
• Swap the current positions of the Tx/Rx configuration items, placing the channel-related stuff on the Config. tab, and the equalization-related stuff on the (newly renamed) Equalization tab.
• Add the capability (on the Config. tab) to select an IBIS, or IBIS-AMI, model for either the Tx, or Rx, or both.
• If an IBIS model was selected, then use it to determine the impedance, etc. of the respective analog component, and don't make any changes to the Equalization tab.
• If an IBIS-AMI model was selected, then do as above, but also configure the Equalization tab to use the DLL/AMI files for equalization mdoeling of the Tx/Rx, as appropriate.

Also, I think David is correct: having a complete link picture somewhere in the GUI, which reflects the current configuration, would be very helpful.

Hi David,

I'm creating this pull request, before merging, to give you a chance to review my changes. Note that (I think) there're no technical changes here; only aesthetic ones. I've given the GUI a complete make-over, taking advantage of the availability of "sub-tabbed" frames, in the Enthought Traits/UI framework. (I've been waiting for this capability for a while now.)

Cheers, -db

Ever since shifting to an exclusively SciKit-RF based approach to channel modeling in PyBERT, we've experienced a dramatic slow-down in that portion of the simulation engine. And the performance of the recently Beta-released v4.0.0 exemplifies this.

There's just too much utility in this approach to channel modeling to abandon it and return to our old ways. It provides a robust, believable, and commonly understood "platform" for building all sorts of composite channel models compatible w/ PyBERT simulation.

So, it's time to profile the code and see how we can improve performance.

Describe the desired new or improved feature. Channel modeling performance that is, at least, as fast as DFE modeling.

Expected behavior Channel modeling performance is no worse than DFE modeling performance.

Screenshots (n/a)

Desktop (please complete the following information): (all)

Additional context (n/a)

Describe the desired new or improved feature. While we're currently able to abort an optimization, we aren't able to abort a simulation. We should have this capability, to handle, for instance:

• when the user launches a simulation having mistyped the number of bits she wants to run.

Expected behavior An item in the Simulation menu, which aborts the currently running simulation when selected. Also, a keyboard shortcut for this menu item.

Screenshots (n/a)

Desktop (please complete the following information):

• OS: (all)
• Python Version (all)
• PyBERT Version (next release)

Additional context (n/a)

With the recent modernization of the Pip package installation infrastructure, it may be time to again attempt to get PyBERT into a "Pip installable" state.

Admittedly, our past attempts at this have been pretty miserable failures. The general sense I have about this is that only real Python wizards succeed and not in a way that can be easily exported to the general PyBERT user base, who must continue to use Anaconda to get a reliable installation of PyBERT up and running. However, in briefly reviewing the advancements embodied by PEP 517 and PEP 518, it seems like it might be worth trying again. And it would be well worth the effort if we succeed, because many folks, who want to use PyBERT, can't use Anaconda for various reasons.

Note: It's important that we do this in a way that leaves us with a "dual-mode" approach. That is, we want to end up in a state where users can install PyBERT (and/or PyAMI), using either conda or pip, with little hassle. (I think 30 minutes is a good "threshold" for the amount of time it should take to get up and running.)

I invite anyone with experience at setting up Python packages for such "dual-mode" installation capabilities to comment here, regarding their experiences. Also, if you are one of the gifted few, who've been successful at getting PyBERT installed and running properly using pip, as opposed to conda, please post your recipe here for others to try.

Thank you! -db

Lately and since working w/ much larger bit streams, I've noticed that clicking a tab in the GUI can cause a segmentation fault. I don't know this for certain, but I believe this may be caused by trying to include too much data in plots.

==> Try reducing the amount of data in the plots, to see if these seg. faults go away.

Describe the desired new or improved feature. A clear and concise description of what is being requested.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows, Linux, or MacOS]
• Python Version [e.g. 3.7.4]
• PyBERT Version [e.g. 3.3.0]

Additional context Add any other context about the problem here.