Perhaps it's something that only irks me, but I find that this syntax quickly becomes readable after the function goes beyond a few lines:

   def publish_this(self, request, obj):
       publish_obj(obj)
   publish_this.label = "Publish"  # optional
   publish_this.short_description = "Submit this article"  # optional

I'm currently using this little decorator to take care of the labels and description which works great:

def create_action(label=None, short_description=None):

    def _create_action(function):
        if label:
            function.label = label

        if short_description:
            function.short_description = short_description

        return function

    return _create_action

Usage is like this:

    @create_action('Publish', 'Submit this article')
    def publish_this(self, request, obj):
        publish_obj(obj)

I have implemented the DOA library exactly as indicated in the example, and am getting a 404 with the following detail:

(model) object with primary key u'0b637de8-ae8a-4fe6-8558-369e9eed2c34/tools/mark_reject' does not exist.

As you can see, i'm using a UUID as my primary key. Might this be a factor? How would you recommend me debugging it? I've gone into the source code and I'm afraid I'm not skilled enough to follow what's happening...

Thanks! Would love for this to work, it would be a lifesaver...

Use django.urls.re_path() when available, instead of the deprecated django.conf.urls.url().

• re_path() is available since Django 2.0.
• url() will be removed in Django 4.0.

Hi guys, Quick question and sorry if it's a bit noobish...

But how do I set the button's url?

For example I want the button to be brought to admin/print/schedule.html

Thanks, Ara

The docs have

    @takes_instance_or_queryset
    def tighten_lug_nuts(self, request, queryset):
        queryset.update(lugnuts=F('lugnuts') - 1)

but this updates all values since queryset seems to ignore the _result_cache (as proven by the test in my first commit). I'm not sure filter(pk=...) is the right way to implement this behavior, but @takes_instance_or_queryset seems dangerous as it is now.

Includes note about that context['original'] is not available when creating / adding new objects (and object actions can't be applied in that case anyways).

If a user wants to use multiple admin extensions that all want to override the change form template they will need to incorporate all the template changes in their own change_form.html

It's therefore a good idea to keep each template customization as clean and simple as possible.

Sorry - I haven't updated the docs to mention this enhancement. If it's a blocker let me know.

Add an @action decorator that behave's like Django's admin.action decorator^1 to clean up customizing object actions.

closes #115

Also relates to #107

Lets say you have a model "model" inside the app "app" with object actions enabled and available for this model. Lets also assume, object app.model with pk=13 exists in the DB.

Calling http://localhost:8000/admin/app/model/13/ works.

Calling the detail view like this http://localhost:8000/admin/app/model/%20%2013/ results in an uncaught 500 (NoReverseMatch). The reason should be, that django allows blanks in its admin urls for the pk variable and the django-object-actions URLs don't.

Hello guys, Is it possible to use the check boxes in the admin UI to filter only the objects that I would like to take place in the queryset, sent to my function? I red the documentation of the package couple of times but couldn't realize how to achieve this. For the moment, it doesn't matter if I have checked something, none or all, I am getting full list of all the objects in the table. It's a great package, though, thank you for sharing it with us :) :100:

for case if object in database has any of special symbols https://github.com/django/django/blob/master/django/contrib/admin/utils.py#L17 clicking on action button causes 404 error, as in SingleObjectMixin there are already parsed kwargs from url, and they are unquoted

made unquoting kwargs

This is a package we're currently using. The main feature we're using is the listview actions. However, because it seems to be no longer maintained, I'm thinking of switching to another one that's maintained.

https://github.com/lukasvinclav/django-admin-actions

Hi, I'm using the takes_instance_or_queryset decorator to re use an existing admin action. The issue is that when I run it in the change_list, the result queryset have all objects, not the custom selection in changelist, don't matter if I only select one o two items. Kind regards Ale

I was recently overriding get_change_actions() as instructed in the documentation, however I was having problems due to a model having a CharField for the primary key, and specifically values that included underscore characters. I was receiving what seemed to be invalid values in object_id which extra characters.

By default the django admin quotes primary key values via the quote() function in "django/contrib/admin/utils.py". This is to prevent certain characters, such as underscores, in the primary key, especially if it's a CharField, from messing up the URL. Therefore, in the admin the object_id is unquoted before calling get_object() and in other cases.

Therefore, I think object_id should also be unquoted before calling get_change_actions so that object_id is not url quoted any more, and operations such as obj = self.model.objects.get(pk=object_id) will succeed as expected.

This PR simply does that. I tried for a short period to get tests running, but I've never installed poetry and was having issues, and just don't have time to debug it right now, so I wasn't able to write a test to confirm the behavior, apologies.

Hi, let me start by expressing my gratitude for your efforts into this nice project !

When actions are related to a certain field, it makes sense to have their button rendered within that field. See for instance: ("Mot de passe" meaning "Password" in French).

I've managed to make the "Reset password" button appear in the password field by dedicating the help_text to it:

class UserChangeForm(admin_forms.UserChangeForm):
    class Meta(admin_forms.UserChangeForm.Meta):
        model = User

    def __init__(self, **kwargs):
        super().__init__(**kwargs)
        password = self.fields.get('password')
        if password:
            password.help_text = \
                """<ul class="object-tools"><li class="objectaction-item" data-tool-name="reset_password">
                <a href="/admin/users/guest/3/actions/reset_password/" title="" class="">Reset password</a>
                </li></ul>
                """

Very hacky, but it hopefully provides you with a useful starting point for implementing this feature, would you consider it.

Cheers