Fixes #52 by deleting a guilds database entries after leaving the guild / if the guild gets deleted. In order to do this I added another database function (remove_guild) which just removes everything directly connected to the guild (message, reactionroles, systemchannels). Please note: This will NOT remove the admin role id from the database as admins table does not refer to which guild the admin role belongs to.

Describe the bug

When using /admin add @Rolecommand in Discord channel as server administrator, bot fails to write to database and produces trackback error in console. Files are all in home directory sub-folders and bot is being run as same user

To Reproduce

Fresh install and setup of bot, authenticated and added to server. Attempt to add admin role to bot.

Expected behavior

Admin role to be added successfully without errors

Screenshots

Server:

• OS: Ubuntu 20.04
• Python version: 3.8
• disnake version: 2.4.0

Traceback

Ignoring exception in slash command 'admin':
Traceback (most recent call last):
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/ext/commands/slash_core.py", line 597, in invoke
    await call_param_func(self.callback, inter, self.cog, **kwargs)
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/ext/commands/params.py", line 778, in call_param_func
    return await maybe_coroutine(safe_call, function, **kwargs)
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/utils.py", line 561, in maybe_coroutine
    return await value
  File "/home/jon/reaction-light-etf/cogs/admin.py", line 43, in admin
    await inter.response.defer()
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/interactions/base.py", line 666, in defer
    await adapter.create_interaction_response(
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/webhook/async_.py", line 214, in request
    raise NotFound(response, data)
disnake.errors.NotFound: 404 Not Found (error code: 10062): Unknown interaction

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/ext/commands/interaction_bot_base.py", line 1332, in process_application_commands
    await app_command.invoke(interaction)
  File "/home/jon/.local/lib/python3.8/site-packages/disnake/ext/commands/slash_core.py", line 606, in invoke
    raise CommandInvokeError(exc) from exc
disnake.ext.commands.errors.CommandInvokeError: Command raised an exception: NotFound: 404 Not Found (error code: 10062): Unknown interaction

If the users have hidden the embed messages in their settings,they only see the reactions attached to an empty message.

This commit aims to make the embed messages 'optionnal' and rely on a normal message. Here's the changes on the commands:

{prefix}new - message formatting (step == 3) :

• some text: Set only a message
• some text // some embed title: Set a message with an embed that only has a title
• some text // some embed title // some embed content: Set a message with an embed that has a title and some contents

{prefix}edit:

• {prefix}edit #channelname // MESSAGE_NUMBER // New Message: Change the message's body
• {prefix}edit #channelname // MESSAGE_NUMBER // New Message // New Embed Title (Optionnal):
  • If the reaction-role message already had an embed, it keeps its existing description, changes its title and the message's body.
  • If the reaction-role message didn't had an embed, it sets one with only a title and the message's body
• {prefix}edit #channelname // MESSAGE_NUMBER // New Message // New Embed Title (Optionnal) // New Embed Description (Optionnal)t:
  • If the reaction-role message already had an embed, it changes its title, its description and the message's body
  • If the reaction-role message didn't had an embed, it sets one with the new title, the new description and the new message body.

{prefix}rm-embed:

• {prefix}edit #channelname // MESSAGE_NUMBER: Remove the embed set on the selected reaction-role message

Even though the bot works flawlessly in its current state (except for the currently open enhancement-related issues), the code could use a lot of improvements.

Refactoring with better functions, classes, cogs, and general usage of discord.py is ideal.

~~We could also consider using SQLite instead of CSV files. Though this will add an extra dependency to the bot (and a complete remake of the bot's file manager (rlightfm)).~~

~~EDIT: Additionally, another hurdle of adopting SQLite is creating a script to transfer the data of CSV files in currently existing installations to the database so to minimise downtime to a simple bot restart.~~

EDIT: Striked parts done in #20

I just installed the bot added with the new command my first reactions

at the point use existing text or make new one i choose the icon to use and existing, believing there is some default

now i cant proceed further, so i restarted the bot and tried the edit command i have to enter a channel and always get the information

There are no reaction-role messages in that channel.

Describe the PR changes

• Adds a new table called guild_settings: I would like to use this for anything guild related in the future, I tried to merge systemchannels into this but I couldn't find an elegant way yet. I will figure it out before merging... Most likely going to copy the contents into a new column and then delete the old table in the one_to_two function
• Moved the admin migration introduced by @Edwinexd from core.database to core.schema (I believe everything should still be working correctly)
• Adds a toggle command rl!notify
• Guilds are inserted into the table when either rl!notify is first used or when the bot checks for it (a user adds or removes a reaction from themselves). In the first case, the bot toggles the notification on, in the latter, the bot sets notifications to off (the "default")

I still need to test this properly, but comments are welcome

Closes #50

Bot deletes Reactionroles though the messages still exist

What happens is, that the bot starts deleting stored Reactionroles for messages that still exists, with the reason, that the message got deleted. In fact, the message didnt get deleted. Its still existing.

To Reproduce

This happened to me when restarting the bot multiple times, each restart made it delete 1 reactionrole. This happened locally, but when running on my Windows VPS 2019, it just did the same thing without any restarts.

Expected behavior

The Bot will delete the Rectionrole

Screenshots

None

Server:

• OS: Windows 10 20H2 / Windows 10 2019 Server
• Python version: 3.8.9
• discord.py version: 1.6

Traceback

Theres no traceback since there isnt any error that came up in console.

Is there an easy way to allow the bot to give multiple roles for each reaction?

I will try to explain the reason for this;

By default a Discord server allows each user to all categories and channels. Perhaps there is too many, so they allow users to react for roles that hide categories/channels. Which is a better method than reacting to see them.

For these roles that hide (or restrict) access to categories/channels, there could be numerous of them. To keep these roles organized, there is 1 main role above all these roles, like a header. For example it might be called ----HIDDEN---- and every role below this header means that role is hiding/restricting view permissions for the corresponding category/channel.

There is also an issue I can see with this- when users un-react to get access back to categ/chan the bot doesn't know better to not take away this header (---HIDDEN---) role. So it would need to know not to touch that header role unless all reactions from the user have been removed/un-reacted.

Hope this makes sense.

One might say "Why not just give that role on join?" which is a fair point. But heres 2 reasons- the first being your bot that gives auto role on join might only be capable of giving 1 role. The other reason is that the whole point of these roles are for channel organization, so users having the header (---HIDDEN---) role without having any roles under it, would look out of place.

Describe the bug

I was running this on my server, it was going smooth until I noticed this error in code.

I would not like trespass here but to contribute, I would like to make the small change needed :)

Fixes #3

A daily task is registered and the bot removes messages that return a discord.NotFound when they are fetched.

Also added message ID reporting of messages that return a 403 if the system channel is set for this feature and also for edit and rm-embed.

Is your feature request related to a problem? Please describe.

Not related to a problem.

Describe the solution you'd like

When users click on a reaction, they lose a role, instead of getting it assigned. unclicking regains them the role.

Describe alternatives you've considered

Haven't been able to come up with any.

Refactor message.py:

• Full rewrite /message new (better code and no more usage of //)
• More functions to avoid repeated code between edit, reaction, and new (e.g. preparation of embeds to send)