When running the program i get an error from mutagen. I have looked around but could not find any related issues:

> $ spotdl https://open.spotify.com/track/398P1VKJo9gJQFZpY3vt8T?si=e_T_AWLySpGDWMMfV-zSBQ Fetching Song... 95%|███████████████████████████████████████████████▍ |ETA: 00:00, 0.09min/songTraceback (most recent call last): File "/home/sjoerdhilhorst/.local/bin/spotdl", line 8, in <module> sys.exit(console_entry_point()) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/spotdl/__main__.py", line 100, in console_entry_point downloader.download_single_song(song) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/spotdl/download/downloader.py", line 274, in download_single_song download_song(songObj, self.displayManager, self.downloadTracker) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/spotdl/download/downloader.py", line 170, in download_song audioFile = EasyID3(convertedFilePath) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/easyid3.py", line 169, in __init__ self.load(filename) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/_util.py", line 185, in wrapper return func(*args, **kwargs) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/_util.py", line 156, in wrapper return func(self, h, *args, **kwargs) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/id3/_file.py", line 152, in load self._header = ID3Header(fileobj) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/_util.py", line 185, in wrapper return func(*args, **kwargs) File "/home/sjoerdhilhorst/.local/lib/python3.6/site-packages/mutagen/id3/_tags.py", line 59, in __init__ raise ID3NoHeaderError("%s: too small" % fn) mutagen.id3._util.ID3NoHeaderError: ./Yotto - Marisa.mp3: too small

Any ideas? i can't find much documentation on what the cause of this exception is

Spot-dl goes haywire for non-mainstream music. It should be possible to implement a search on music.youtube.com with pyselenium instead of using the YouTube search api. This will ensure the correct song is found. To the best of my knowledge the music.youtube-url's can be downloaded just like normal url's.

This PR aims to remove multiprocessing in favor of asyncio. It could still use some refactoring, but seem to work fine.
I've left the prints for now, to show that the code is executed in parallel and the poolSize is respected.

The change seems to not affect performance, and the code should be much easier to test and debug.

Asyncio code:

real    2m52.298s
user    7m43.636s
sys     1m1.016s

Original code:

real    2m52.413s
user    7m24.404s
sys     1m0.423s

I'm having a problem when I download a song or playlist from spotify but I never had a problem with spotdl, I always use it and it works great for me (thanks to the developers for that). I use the "spotdl" command with the playlist or song link. The following error appears on the console: "as no match could be found on youtube". I hope you can solve it, maybe it is temporary or maybe because of the Google servers crash a few days ago that affected YouTube, however I download from Spotify. Thank you very much to all!

**[email protected]:**/mnt/c/Users/Mateo/Documents/HACKING/Linux/spotify-downloader$ spotdl https://open.spotify.com/track/2rc7BkzO8qepMFAxHtOrXc
Fetching Song...
Skipping Blanco (https://open.spotify.com/track/2rc7BkzO8qepMFAxHtOrXc) as no match could be found on youtube
  0%|                                                 |ETA: ?, ~min/song

What follows is a lit of features already ready for addition or requested by the community. Drop a 👍 if you'd use, and a 👎 if you wouldn't use it.

UPDATE

1. Features that the spotDL team think are worth adding will be moved to #912. Please vote over there.
2. As to the features requested before 23/10/2020, they will be considered purely on the basis of votes received.
3. Feel free to start conversations in this Issue/thread.

Drop TQDM in favor of willmcgugan/rich This was #1037 before branch convention changes. #1037 was part of #895 but I created a new PR after asyncio switch.

Before:

After:

See #1037 for more info.

Environment

• System OS: Windows 10

• Python Version: Python 3.9.4

• Install Source: CMD, pip

• Version OR Commit hash:

Version: 3.5.2
Summary: Download your Spotify playlists and songs along with album art and metadata
Home-page: https://github.com/spotDL/spotify-downloader
Author: spotDL Team
Author-email: [email protected]
License: MIT
Location: c:\pl\python39\lib\site-packages
Requires: pytube, beautifulsoup4, mutagen, tqdm, spotipy, ytmusicapi, rapidfuzz, requests, rich
Required-by:

Expected Behaviour

1. I'm trying to download The Longest Johns' Oak & Ash & Thorn, and expect that it downloads this video: https://music.youtube.com/watch?v=4GT59EqPlUQ&list=RDAMVM4GT59EqPlUQ.

• The program will convert the whole hour, which isn't really a good thing to see since it's really just a small song, therefore the system to search the song has a wrong download

2. I'm trying to download chumachechaya vesna/Чумачечая Весна and it doesn't detect the Youtube Music link: https://music.youtube.com/watch?v=A-PjXUzhFDk&list=RDAMVMA-PjXUzhFDk

• The program will instead error out, and this is possibly actually due to its foreign characters being recognized. Translating it to English creates a "song not found" error on Spotify, and manually typing it creates a "song not found" on Youtube instead.

Actual Behaviour

For Oak & Ash & Thorn, it downloads this 1 hour video: https://www.youtube.com/watch?v=zIHmPlI4JEs For Chumachechaya Vesna, the song can't be found.

Steps to Reproduce

1. Run "spotdl https://open.spotify.com/track/38FCXf9CTcH9MJKn3WsJ7x"
2. Run "spotdl https://open.spotify.com/track/2eaSMmKfigsm96aTUJMoIk"

Traceback

For Oak & Ash & Thorn:

D:\Downloads\Audio\Music\Spotdl>spotdl https://open.spotify.com/track/38FCXf9CTcH9MJKn3WsJ7x
Fetching Song...
Searching for: The Longest Johns - Oak & Ash & Thorn
The Longest Johns - Oak & Ash & Thorn              Converting         ------------------------------------------------------------         90% 0:00:02

For Chumachechaya Vesna:

D:\Downloads\Audio\Music\Spotdl>spotdl https://open.spotify.com/track/2eaSMmKfigsm96aTUJMoIk
Fetching Song...
Searching for: Potap & Nastya - Чумачечая весна
Skipping Чумачечая весна (https://open.spotify.com/track/2eaSMmKfigsm96aTUJMoIk) as no match could be found on youtube

D:\Downloads\Audio\Music\Spotdl>spotdl "Potap & Nastya - chumachechaya vesna"
Searching for song "Potap & Nastya - chumachechaya vesna"...
No song matches found on Spotify

D:\Downloads\Audio\Music\Spotdl>spotdl "Potap & Nastya - Чумачечая весна"
Searching for song "Potap & Nastya - Чумачечая весна"...
Searching for: Potap & Nastya - Чумачечая весна
Searching for: Potap & Nastya - Чумачечая весна - Live
Searching for: Potap & Nastya - Чумачечая весна
Could not match any of the results on YouTube

D:\Downloads\Audio\Music\Spotdl>spotdl "Потап и Настя - Чумачечая Весна
Searching for song "Потап и Настя - Чумачечая Весна"...
Searching for: Potap & Nastya - Чумачечая весна
Searching for: Potap & Nastya - Чумачечая весна - Live
Searching for: Potap & Nastya - Чумачечая весна
Could not match any of the results on YouTube

Any other information:

Related to other previous issues I've given, specifically #970 and #1089.

Reviewing the code in download.py also reveals a failure to check returns codes from the spawned ffmpeg process, and that's the root cause of the problem I've encountered. If ffmpeg fails for any reason, the spotDL code will keep on working. If the output file isn't written, it ends up hanging with 100% CPU usage due the loop I quoted above.

For me, the issue is that I've got ffmpeg version 7:4.1.6-1 installed. This is the newest official version for the Raspberry Pi:

$ sudo apt install ffmpeg
Reading package lists... Done
Building dependency tree
Reading state information... Done
ffmpeg is already the newest version (7:4.1.6-1~deb10u1+rpt1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

However, that version doesn't support the pad_dur option for the apad filter. spotDL passes this filter in the chian (as apad=pad_dur=2). ffmpeg fails, that failure isn't detected; ffmpeg writes a zero-byte output file, spotDL doesn't care to check, and crashes.

Getting a newer version of ffmpeg from snap exchanges this problem for another issue:

$ sudo snap install ffmpeg --classic
2021-01-25T15:54:27-08:00 INFO Waiting for restart...
ffmpeg N-76538-gb83c849 from Snapcrafters installed
Channel latest/stable for ffmpeg is closed; temporarily forwarding to stable.

because that version doesn't support the -abr option. I'll hve to find a way to get a version compatible with spotDL.

Until then, a raw Python stack dump is pretty harrowing for most users. Maybe the spotDL developers will consider any of these suggestions to improve matters for their users:

• Document the required version of ffmpeg as 4.2 or newer (when pad_dur support was added)
• Check the ffmpeg version at startup; if older, omit the pad_dur parameter; perhaps with a warning message
• add code that checks the process.returncode in download.py to see if the spawned process failed or worked; if it fails, do something sensible instead of trying to process a broken output file
• catch the piped output from the process to develop a clear error message. ffmpeg shows the user an actionable error message
• add a --debug option to the script to share more output

Reinstalling Python, as recommended above, won't fix this issue.

Originally posted by @mikeblas in https://github.com/spotDL/spotify-downloader/issues/934#issuecomment-767195102

First, sorry for using old version :(

• added .python-version This file is used in pyenv to select good python version.

Changes in core/misc.py:

• added function get_sec to convert HH:mm:ss to seconds

Changes in spotdl.py:

• in function generate_songname change function to receive generate_metadata, this is optymalization, becouse in oldest version metadata from spotify api is downlaoded 2 times
• in function generate_youtube_url song variable use changed function generate_songname function now looking for songs in while, and save data to dict. Dictionary is used in manual and auto mode. In dictionary keep is youtube link, title, videotime (in format HH:mm:ss) and videotime converted to seconds. For now in automatic downloading is selected video with least difference betwen youtube video time and time from spotify. This is important, becouse in youtube a lot of movies has scenes before/after without musics.

Title

restructured project; various bugfixes and improvements

Description

• Changed project structure
• Added yt as fallback provider
• Follow pep8 guidelines in the whole project
• create .m3u file
• fixed tests
• renamed .cache to .spotdl-cache
• download audio with youtube-dl
• improved audio quality and conversion time for m4a and opus
• bugfixes
• more...

Related Issue

Motivation and Context

I don't like current project structure. It's quite hard to navigate in the project.

How Has This Been Tested?

pytest, mypy, flake8

Screenshots (if appropriate)

Types of Changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] My code follows the code style of this project
• [x] My change requires a change to the documentation
• [x] I have updated the documentation accordingly
• [x] I have read the CONTRIBUTING document
• [x] I have read the CORE VALUES document
• [x] I have added tests to cover my changes
• [x] All new and existing tests passed

Hello,

I'm having a problem while downloading playlist. It suddenly stops at 4%. I've tryed multiple times with different playlists. Version I'm running is 3.1.4. I got python and ffmpeg installed, as well as pytube which I was troubleshooting while I searching for solution on google (uninstalling and installing it). Am I missing someting ? Can anyone help me please ?

C:\Users\darko>spotdl https://open.spotify.com/playlist/7JAdfJue28XcbNFaAM7xKf
Fetching Playlist...
  4%|███▍                                                                                     |ETA: 03:55, 0.03min/songmultiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 114, in download_song
    downloadedFilePath = trackAudioStream.download(
AttributeError: 'NoneType' object has no attribute 'download'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\multiprocessing\pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\multiprocessing\pool.py", line 51, in starmapstar
    return list(itertools.starmap(args[0], args[1]))
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 124, in download_song
    remove(join(tempFolder, convertedFileName) + '.mp4')
FileNotFoundError: [WinError 2] The system cannot find the file specified: '.\\Temp\\Regard, RAYE - Secrets - Tom Field Remix.mp4'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\darko\AppData\Local\Programs\Python\Python38-32\Scripts\spotdl.exe\__main__.py", line 7, in <module>
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\__main__.py", line 116, in console_entry_point
    downloader.download_multiple_songs(songObjList)
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 293, in download_multiple_songs
    self.workerPool.starmap(
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\multiprocessing\pool.py", line 372, in starmap
    return self._map_async(func, iterable, starmapstar, chunksize).get()
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\multiprocessing\pool.py", line 771, in get
    raise self._value
FileNotFoundError: [Errno 2] The system cannot find the file specified: '.\\Temp\\Regard, RAYE - Secrets - Tom Field Remix.mp4'

Edit : Just tryed to download a song

C:\Users\darko>spotdl https://open.spotify.com/track/5HFPK8mcO6BGPZNeZPZI5L
Fetching Song...
  0%|                                                                                                                                  |ETA: ?, ~min/songTraceback (most recent call last):
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 114, in download_song
    downloadedFilePath = trackAudioStream.download(
AttributeError: 'NoneType' object has no attribute 'download'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\darko\AppData\Local\Programs\Python\Python38-32\Scripts\spotdl.exe\__main__.py", line 7, in <module>
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\__main__.py", line 100, in console_entry_point
    downloader.download_single_song(song)
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 274, in download_single_song
    download_song(songObj, self.displayManager, self.downloadTracker)
  File "c:\users\darko\appdata\local\programs\python\python38-32\lib\site-packages\spotdl\download\downloader.py", line 124, in download_song
    remove(join(tempFolder, convertedFileName) + '.mp4')
FileNotFoundError: [WinError 2] The system cannot find the file specified: '.\\Temp\\Ytram, Martin Garrix - Fire (with Elderbrook).mp4'
  0%|                                                                                                                                  |ETA: ?, ~min/song

C:\Users\darko>

Requested Feature

It's not really a request but rather a question. If i pass --ffmpeg-args "-c:a libfdk_aac" will it do after song has been downloaded or first will do -c:a aac (which is default i presume) and then ffmpeg-args?

Possible implementation

No response

System OS

Windows

Python Version

3.10 (CPython)

Install Source

pip / PyPi

Install version / commit hash

4.0.6

Expected Behavior vs Actual Behavior

Downloading "STAY - The Kid LAROI" outputs a one hour long video from youtube instead of the normal version

Expected

Expected Behavior: spotdl will find this: https://music.youtube.com/watch?v=XfEMj-z3TtA (2:38 duration)

Actual

Actual Behavior- spotdl finds a 1 hour long duration audio: https://www.youtube.com/watch?v=aM3owjYjQKk (1:00:01)

spotdl download https://open.spotify.com/track/5PjdY0CKGZdEuoNab3yDmX
Downloaded "The Kid LAROI - STAY (with Justin Bieber)": https://www.youtube.com/watch?v=aM3owjYjQKk

Steps to reproduce - Ensure to include actual links!

spotdl download https://open.spotify.com/track/5PjdY0CKGZdEuoNab3yDmX

Traceback

spotdl download https://open.spotify.com/track/5PjdY0CKGZdEuoNab3yDmX
Downloaded "The Kid LAROI - STAY (with Justin Bieber)": https://www.youtube.com/watch?v=aM3owjYjQKk

### Other details

_No response_

Requested Feature

Hello! Please add the ability to download multiple tracks from YouTube Music with metadata from Spotify. I just have an album with Russian metadata, and which is uploaded to YouTube music with English metadata. Everything works fine for one track, but you can kill yourself by downloading 14 tracks one at a time. Please add this feature if possible.

Possible implementation

No response

Requested Feature

Ability to store the Spotify URL that was provided initially inside the details properties of the downloaded music, either by replacing the YouTube Music URL or by appending/prepending it.

This link will be useful for sharing and record-keeping purposes.

Possible implementation

No response

Bugfixes/improvements:

• Match existing songs by spotify URL instead of name by @Domi250 in https://github.com/spotDL/spotify-downloader/pull/1641
• Improved matching for japanese songs by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/513cefa16742a4d602245e345b32a06181965f13 https://github.com/spotDL/spotify-downloader/commit/57482fcae5ecb62485dc8925312337ca2a5befa1
• Improved song matching for results with merged artists by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/ffda0afcc57b3a19a0dacb3d296f5309a0a11651
• Fixed some errors related to unicode encoding by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/4380cea538308cd0535497e7c2b45533ead934f7

API changes:

• Unified matching algorithm for all audio providers by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/396c588dd335f3359a1faa205a06
• Rewritten metadata module, added function to get song metadata from files by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/7d01556643eb7bf3c447ec8305b87d0516b45ec0
• Don't raise error on empty results list by @xnetcat in https://github.com/spotDL/spotify-downloader/commit/35be8b3a84d9f3d9e6493cccbab7ca899846a4dd

TODO:

• Add synced lyrics

A lot more changes to come...