Code review pyramid

When it comes to code review , A common phenomenon is a lot of attention and lengthy discussion around trivial aspects such as code format and style , And important aspects （ Does the code change accomplish what it should do , Whether it has performance ？ Whether it is backward compatible with existing customers and many other customers ） Often receive less attention .

In order to raise awareness of this issue and provide some guidance on areas that need attention , I was in a few days ago Twitter I shared a Little picture , I call it “ Code review pyramid ”. Its purpose is to help focus attention on the most important parts during code review （ in my opinion , in any case ）, And what parts can and should be automated .

Because some people ask for the permanence of this resource 、 Reference location , Others want a high-resolution printed version , I put it here again ：

​​​​​​​

 

You can also download the visual file as SVG file .

Always ask questions

• Why pyramids ？

  The bottom half of the pyramid should be the basis for code review , And occupy most of them .

• well , This is a triangle ！

  You might think so , But from the side, it is a pyramid .

• Which tool do you use to create drawings ？

  Magic sword .