Use try-with-resources or close this

Use try-with-resources or close this "FileOutputStream" in a "finally" clause.

Original code ：

Log in and copy

      
      

       
        /**     * @param contents  binary data      * @param filePath  File storage directory , Include the file name and its suffix , Such as D:\file\bike.jpg
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
         * @Title: byteToFile     * @Description:  Convert binary data into a file with a specified suffix , for example PDF,PNG etc.      */
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
         public static void byteToFile(byte[] contents, String filePath) throws IOException {
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
             FileOutputStream fos = null;        BufferedOutputStream output = null;
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
           try (  BufferedInputStream bis = new BufferedInputStream(new ByteArrayInputStream(contents))){
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
              File file = new File(filePath);
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
        //  Get the parent path string of the file 
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
        File path = file.getParentFile();
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
         if (!path.exists()) {
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
        log.info(" Folder does not exist , establish .path={}", path);
      
      
      
      

       
       
1.
      
      

Log in and copy

      
      

       
           boolean isCreated = path.mkdirs();                if (!isCreated) {                    log.error(" Failed to create folder ,path={}", path);                }            }            fos = new FileOutputStream(file);            //  Instantiation OutputString  object             output = new BufferedOutputStream(fos);            byte[] buffer = new byte[1024];            int length = bis.read(buffer);            while (length != -1) {                output.write(buffer, 0, length);                length = bis.read(buffer);            }            output.flush();        } catch (Exception e){            log.error(" Throw exception when outputting file stream ,filePath={}", filePath, e);        } finally {            if (output != null) {                try {                    output.close();                } catch (IOException e) {                    e.printStackTrace();                }            }            if (fos != null) {                try {                    fos.close();                } catch (IOException e) {                    e.printStackTrace();                }            }        }    }
      
      
      
      

       
       
1.
      
      

Use sonar Scanned out bug Need repair . The result after modification is ：

Log in and copy

      
      

       
         /**     * @param contents  binary data      * @param filePath  File storage directory , Include the file name and its suffix , Such as D:\file\bike.jpg     * @Title: byteToFile     * @Description:  Convert binary data into a file with a specified suffix , for example PDF,PNG etc.      */    public static void byteToFile(byte[] contents, String filePath) throws IOException {        FileOutputStream fos = null;        BufferedOutputStream output = null;        try (  BufferedInputStream bis = new BufferedInputStream(new ByteArrayInputStream(contents))){            File file = new File(filePath);            //  Get the parent path string of the file             File path = file.getParentFile();            if (!path.exists()) {                log.info(" Folder does not exist , establish .path={}", path);                boolean isCreated = path.mkdirs();                if (!isCreated) {                    log.error(" Failed to create folder ,path={}", path);                }            }            fos = new FileOutputStream(file);            //  Instantiation OutputString  object             output = new BufferedOutputStream(fos);            byte[] buffer = new byte[1024];            int length = bis.read(buffer);            while (length != -1) {                output.write(buffer, 0, length);                length = bis.read(buffer);            }            output.flush();        } catch (Exception e){            log.error(" Throw exception when outputting file stream ,filePath={}", filePath, e);        } finally {            if (output != null) {                try {                    output.close();                } catch (IOException e) {                    e.printStackTrace();                }            }            if (fos != null) {                try {                    fos.close();                } catch (IOException e) {                    e.printStackTrace();                }            }        }    }
      
      
      
      

       
       
1.
      
      

After scanning

Prompt no problem , The result is perfect ！

The modification opinions given by the audit tool are ：

Log in and copy

      
      

       
       try (    FileReader fr = new FileReader(fileName);    BufferedReader br = new BufferedReader(fr)  ) {    return br.readLine();}catch (Exception e) {    log.error("error:{}", e);}
      
      
      
      

       
       
1.
      
      

try(){

}catch (Exception e) {

}

Written in try（） It will automatically close the flow, and there is no need to continue other operations , as for try What is defined inside needs to be redefined finally Shut down